fix: enable uploads to ghcr.io, upload binaries to github #4368
+45
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
reviewed
Jan 2, 2025
.github/workflows/pr.yaml
Outdated
| # run: | | ||
| # docker load --input /tmp/${{ matrix.docker-image }}.tar | ||
| # docker push "${{ env.CI_CONTAINER_REPOSITORY }}/${{ matrix.docker-image }}:${{ needs.ci-generate-tag.outputs.tag }}" | ||
| - name: Login to ghcr |
There was a problem hiding this comment.
Suggested change
| - name: Login to ghcr | |
| - name: Login to GHCR |
.github/workflows/pr.yaml
Outdated
| # docker push "${{ env.CI_CONTAINER_REPOSITORY }}/${{ matrix.docker-image }}:${{ needs.ci-generate-tag.outputs.tag }}" | ||
| - name: Login to ghcr | ||
| run: echo ${{ secrets.WEAVE_GITOPS_BOT_ACCESS_TOKEN }} | docker login ghcr.io -u weaveworks --password-stdin | ||
| - name: Push images to gcloud |
There was a problem hiding this comment.
Suggested change
| - name: Push images to gcloud | |
| - name: Push images to GHCR |
There was a problem hiding this comment.
@erikgb
${{ secrets.WEAVE_GITOPS_BOT_ACCESS_TOKEN }}
I think we need to use this token
There was a problem hiding this comment.
I hope not. I think we should try to be as much key/secret less as possible. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Why was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes